chore: Format reportError log #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Dec 19, 2024
| val severityString = err.severity.name.take(1) + err.severity.name.drop(1).toLowerCase(Locale.ROOT) | ||
| val severityString = err.severity match { | ||
| case Level.ERROR => "Error" | ||
| case Level.WARN => "Warning" |
There was a problem hiding this comment.
Warn => Warning was the reason I changed this, but seems better to do a full match than the letter conversions
| val message = s"$severityString reported from Akka runtime: ${err.code} ${err.message}" | ||
| val detail = if (err.detail.isEmpty) Nil else List(err.detail) | ||
| val seeDocs = DocLinks.forErrorCode(err.code).map(link => s"See documentation: $link").toList | ||
| val messages = message :: detail ::: seeDocs | ||
| val logMessage = messages.mkString("\n\n") | ||
| val logMessage = messages.mkString("\n") |
There was a problem hiding this comment.
I don't think this extra newline is helpful. Looks like this:
07:29:10.966 INFO akka.runtime.VersionCheck - A newer version of the SDK [3.0.2] is available. Your current version is [3.0.1-52-ded12af8-SNAPSHOT].
07:29:10.968 WARN akka.javasdk.ServiceLog - Warn reported from Akka runtime: AK-00011 A newer version of the SDK [3.0.2] is available. Your current version is [3.0.1-52-ded12af8-SNAPSHOT].
To fix this issue, update the version of akka-javasdk in your Akka service. Then build and deploy a new version of it.
07:29:11.608 INFO akka.runtime.DiscoveryManager - Building component [counter-command-from-topic]
johanandren
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.